Code Critic round 2. rzf submitted this code. I tried to indent it like I would, so don’t rail him if you don’t like the indents, it’s my fault.

A couple of notes: I’ve enabled HTML in my comments. If you want to post code there, you can with a little more control over how you want it to look. If you want your code critiqued, it’s still probably best to email it to me.

Jan suggested that I present a problem for Code Critic and have readers supply the code. I thinks that’s a good idea. If nobody sends code to be criticized, I’ll do it, otherwise I’ll post what you send me.

Private Sub Workbook_Open()
    Const sngVer As Single = 2003
    ‘Check for new version
    Application.ScreenUpdating = False
    Application.DisplayAlerts = False
    Application.EnableCancelKey = xlDisabled
    On Error Resume Next
    ‘open versioning file on network and save to c:
    Workbooks.Open Filename:=”G:deptsprovrembprovreimversions.txt”
    If Err.Number <> 1004 Then ActiveWorkbook.SaveAs Filename:=”c:program filesmicrosoft officeofficeversions.txt”
    If Err.Number = 1004 Then ‘not on network, used saved file
        Err.Clear
        Workbooks.Open Filename:=”c:program filesmicrosoft officeofficeversions.txt”
    End If
    If Err.Number <> 1004 Then
        If Range(“B12?) <> sngVer Then
            If MsgBox(“Version ” & Range(“B12?) & ” is now available.” & vbCrLf & “You are currently running version ” & sngVer & “.” & vbCrLf & vbCrLf & “You will need to update to the newest version to make sure you have the most current bug fixes, formatting changes, and revised forms.” & vbCrLf & vbCrLf & “If, for some odd reason, you need to use this old version then click “”YES”” below. Note, though, that no further support is available for this version”, vbInformation + vbYesNo + vbDefaultButton2, “Update Available”) = vbNo Then
                Workbooks(“versions.txt”).Close SAVECHANGES:=False
                ActiveWorkbook.Close SAVECHANGES:=False
                Application.EnableCancelKey = xlInterrupt
                Exit Sub
            End If
        End If
    Else ‘couldn’t open either file (this should never happen, but just in case)
        MsgBox “The version number could not be verified. Please be sure you are using the most current version before continuing.”, vbInformation, “Version Check Error”
    End If
    
    Workbooks(“versions.txt”).Close SAVECHANGES:=False
    Application.EnableCancelKey = xlInterrupt
    Application.ScreenUpdating = False
    Range(“A1?).Select
    ActiveWindow.Zoom = True
End Sub

Here are my comments:
Your lines are too long. I post in the newsgroups a lot so I have this bad habit of making my lines too short. But yours are incredibly long. I don’t know how you maintain that. Anyway, I would put my MsgBox messages in variables and use some line continuation characters so I could read and edit them without scrolling.

In your second If block, you use an unqualified Range reference (Range(“B12?)). I’m sure this works for you, but I’m not sure how. With this sub in the ThisWorkbook module, it seems that B12 would be on the ActiveSheet of ThisWorkbook, not the ActiveWorkbook. I’m sure it’s just one of those default object references that I don’t completely get, but you should consider qualifying that reference.

If I were writing this, I would use a Workbook variable and test it for Nothing instead of using the err numbers.

Set oVerWb = Workbooks.Open(Filename:=sNetPath & sFleNm)
If oVerWb Is Nothing Then
    Err.Clear
    Set oVerWb = Workbooks.Open(Filename:=sLocPath & sFleNm)
End If
If Not oVerWb Is Nothing Then
    With oVerWb
        .SaveAs sLocPath & sFleNm
            If .Sheets(1).Range(“B12?).Value <> sngVer Then